`hubble.audit` fails if a bad yaml file is located in the `hubblestack_nova` directory

Question

`hubble.audit` fails if a bad yaml file is located in the `hubblestack_nova` directory

Closed this issue 9 years ago · 4 comments

_get_yaml function in each nova plugin will try to load all the yaml files in the hubblestack_nova directory. If at least one of the yaml files in there is having a bad yaml syntax, the except block will be reached and an empty dict will be returned.

I'd suggest the yaml.parser.ParserError exception to be treated for each opened file.

Answer 1 · 2016-04-25T16:45:46.000Z

@basepi, any thoughts on this one? Should I put the error string in the log?

Answer 2 · 2016-04-25T21:43:28.000Z

I think I'll take this one as part of #68. I'm going to move the yaml loading into hubble.py to allow for #69. I'll probably just report yaml loading errors in the output of the audit, under failures.

Answer 3 · 2016-04-29T02:57:52.000Z

Is this still relevant?

Answer 4 · 2016-04-29T16:45:45.000Z

No. If an error occurs when loading yaml, it will be reported in the output of hubble.load