hubblestack/pulsar

Different format for regex checks

Closed this issue · 3 comments

Should we consider using a different format for the regex checks? Instead of each item being a dict with regex: True underneath it, would it be better to do something like this?:

- /ignore/me
- /me/too
- regex:
  - \/iLoveRegex\./d*$
  - \/regex\/forLife
- potentially/other/files

As opposed to what it is now:

- /ignore/me
- /me/too
- \/iLoveRegex\./d*$:
    regex: True
- \/regex\/forLife:
    regex: True
- potentially/other/files

It think we should leave it as is. Although it's more verbose, it's also more salt-y. I don't love the idea of magic keys in dictionaries, especially because this config just isn't going to get all that long or change all that often in the long run.

+1

On Mon, Aug 29, 2016, 3:04 PM Colton Myers notifications@github.com wrote:

It think we should leave it as is. Although it's more verbose, it's also
more salt-y. I don't love the idea of magic keys in dictionaries,
especially because this config just isn't going to get all that long or
change all that often in the long run.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#22 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgonW8AoeAzMsjWTo5oJJEwKDiqhsi-ks5qk0lPgaJpZM4Jv2br
.

(I closed this assuming Christer was +1-ing my comment, but I could be wrong. In any case, conversation can definitely continue. :) )