hubblestack/quasar

splunk_nova_return stacktraces when handed an error from nova

basepi opened this issue · 1 comments

If nova can't fetch the data, it will return (False, 'No nova modules/data have been loaded.’), which stacktraces splunk_nova_return:

[ERROR   ] An un-handled exception was caught by salt's global exception handler:
AttributeError: 'tuple' object has no attribute 'get'
Traceback (most recent call last):
  File "hubble.py", line 5, in <module>
  File "hubblestack/daemon.py", line 52, in run
  File "hubblestack/daemon.py", line 75, in main
  File "hubblestack/daemon.py", line 249, in run_function
  File "/opt/hubble/hubble-libs/hubblestack/extmods/returners/splunk_nova_return.py", line 90, in returner
    for fai in data.get('Failure', []):
AttributeError: 'tuple' object has no attribute 'get'
Traceback (most recent call last):
  File "hubble.py", line 5, in <module>
  File "hubblestack/daemon.py", line 52, in run
  File "hubblestack/daemon.py", line 75, in main
  File "hubblestack/daemon.py", line 249, in run_function
  File "/opt/hubble/hubble-libs/hubblestack/extmods/returners/splunk_nova_return.py", line 90, in returner
    for fai in data.get('Failure', []):
AttributeError: 'tuple' object has no attribute 'get'
Failed to execute script hubble

Should be easy to fix, just need to check for the tuple.

This issue was moved to hubblestack/hubble-salt#19