Code and config file in the Reporter should be refactored to accommodate ASCT+b tables in their new location.
Closed this issue · 9 comments
Currently, all of the ASCT+B tables are stored in a single Google Sheets workbook with many sheets.
Now, in ASCt+B Google Drive, we're making a dedicated folder for ASCT+B tables, with organ names as subfolders, and version-specific files for each organ in the dedicated folders.
@emquardokus Please, provide a link once you have everything ready, in order for us to begin
@vutukuriajay2241 @bherr2
Here are the folder urls and individual ASCT+B organ table versions.
They are named according to what the ccf-release name is for those that are already DOI'd.
The ones with DRAFT at the end are the current quarter's working draft and should NOT be published YET in the ASCT+B reporter---authors will use the playground feature or the compare feature to visualize new tables until we publish them for next CCF-release v1.2.
Outer folder + ALL organ folders including NEW template:
CCF Release v1.2 DRAFT tables ONLY
All versions of ASCT+B tables including working DRAFT
@emquardokus new locations are now on staging https://ccf-asct-reporter.netlify.app/. You can close this after you've reviewed.
@bherr2
There are problems with staging and not sure the origin as the original tables, links and versions listed in this ticket that I provided are correct.
From Master Tables drop down listing of versioned tables (
NOTE, the "go to visualization is correctly listing ONLY published tables)
**The issues I'm seeing at the staging site are as follows: **
- original 11 organs should have 3 versions, but in some cases the v1.2 DRAFT is missing; the exception are Blood and Bone marrow because v1 was together and v1.1 were split and blood vasculature v1.1 was published as vasculature v1.0, but both should have v1.2 DRAFT
Blood,Blood Vasculature, Bone marrow, Brain, Heart, Kidney, Large intestine, Lymph node, Lung, Skin, Spleen, Thymus
should have v1.0, v1.1 and v1.2 DRAFT
-
organ tables that had their first v1.0 published in December 2021 will have v1.1 DRAFT
Eye, Fallopian tube, Ovary, Pancreas, Prostate,Small intestine, Ureter, Urinary bladder, Uterus,
should have v1.0 and v1.1 DRAFT -
organ tables that will be brand new for Q3 will have v1.0 DRAFT
Placenta, Spinal cord and Breast
Should have v1.0 DRAFT only
=========
These organs are missing their DRAFT versions entirely: Lung
Lung should have 3 versions: v1, v1.1, v1.2 DRAFT
==========
These are the organs are missing the word "DRAFT" after their latest versions. (I think some confusion may be occurring in that NOT all v1 and v1.1 are published for all organs) This gets back to the CCF_release version numbering vs the ASCT+B table version numbering.
These table names should be denoted as "v1.1DRAFT" as they are the working versions for Q3:
Eye, Fallopian Tube, Heart, knee, liver, lymph vasculature, ovary, pancreas, peripheral nervous system, prostate, small intestine, urinary bladder, uterus
ureter is missing the draft table altogether
=========
Placenta, Spinal cord and Breast are new for quarter 3, first version tables, all are DRAFT.
v1.0 DRAFT
Placenta is currently showing v1.0 needs to be updated v1.0 DRAFT
Spinal cord is correct showing v1.0 DRAFT
Breast is correct showing v1.0 DRAFT
============
These have incorrect DRAFT numbers: Brain v1.1DRAFT should be Brain_v1.2_DRAFT, Heart v1.1DRAFT should be Heart_v1.2_DRAFT, Large_Intestine_v1.1_DRAFT should be Large_Intestine_v1.2_DRAFT, Lymph node
Brain, large intestine, lymph node,
@Nikhil-lab let us know if you have any questions about these changes.
ok @bherr2
@bherr2, @emquardokus, @katyb
We have three options for the Draft versions. Please let @Nikhil-lab and me know which one need to be done.
- Do we need completely remove Draft tables from the config file?
- Do we need have in both the config file and show them on the UI?
- Do we need have in both the config file and hide them on the UI?
Sheet configs should only be in sheet-config.json (and not in configuration.json). Keep drafts. In the visualization chooser, hide DRAFTs unless 'visible' = true (sort by Label). In Master Tables dropdown, do not filter out Drafts.
@Nikhil-lab Are you clear now? Please let us know if you have any questions?