bug: SafeTransferLib
obatirou opened this issue · 4 comments
Its interesting that merging the above pr did not break ci, do you know your current fuzzer seed?
I don't believe this is a bug, but thank you for reporting 😄
If you notice, the to address is the Hardhat console address, and that contract is not rejected by the test because it has no code (foundry hooks into it when it receives a call, and reverts forcefully if no selectors match).
We should fix up this test to exclude the console and VM addresses.
I don't believe this is a bug, but thank you for reporting 😄
If you notice, the
toaddress is the Hardhat console address, and that contract is not rejected by the test because it has no code (foundry hooks into it when it receives a call, and reverts forcefully if no selectors match).We should fix up this test to exclude the console and VM addresses.
Oh you’re right, thank you !
I should have not labeled this issue as a bug without looking into it a little bit. Unfortunately, did not have time when discovering this failing test.
It should have been tagged as a failing test and not a bug until confirmation.
I will make sure to pay more attention next time !
I don't believe this is a bug, but thank you for reporting smile
If you notice, thetoaddress is the Hardhat console address, and that contract is not rejected by the test because it has no code (foundry hooks into it when it receives a call, and reverts forcefully if no selectors match).
We should fix up this test to exclude the console and VM addresses.Oh you’re right, thank you ! I should have not labeled this issue as a bug without looking into it a little bit. Unfortunately, did not have time when discovering this failing test. It should have been tagged as a failing test and not a bug until confirmation. I will make sure to pay more attention next time !
No worries! Better safe than sorry, much appreciated.