huggingface/deep-rl-class

[UPDATE] Unit2 Q-tables typo

PierreCounathe opened this issue ยท 4 comments

Typos in the (learned) Q-tables

  • I think there is a typo in both images of the learned Q-tables in pages Introducing Q-Learning and Q-Learning Recap of the Unit 2 of the course. On the fourth line of the table, the -10 coefficient should appear in the second column (take a step to the right). I thought this might be confusing to people who pay attention to tables more than text.
  • The typo also appears in the notebook as the same file is used.
  • Cf below for the screenshots that show both the game setup and the learned Q-tables.
  • I could not open a PR as I could not access the hosted image files.

Screenshots

Hey there ๐Ÿ‘‹ thanks for pointing this out. Indeed there's an error. I'm updating the illustration

Updated โœ…

Hi @simoninithomas, thanks for the update!

I should have mentioned this, but there are two files used by the .mdx files.
q-learning.mdx uses this (second) file: https://huggingface.co/datasets/huggingface-deep-rl-course/course-images/resolve/main/en/unit3/Q-learning-1.jpg, that was not updated I think.

I see thanks for pointing this out I update it ๐Ÿค—