[HANDS-ON BUG] Unit-1: make sure model_name is not empty
znacer opened this issue ยท 2 comments
znacer commented
Describe the bug
This bug is found in the following notebook : Unit-1
In section Train the PPO agent ๐
, an empty string is assigned by default to variable model_name
.
If one let this value to empty, an error will be raised in section Load a saved LunarLander model from the Hub ๐ค
. When user try to upload his model with an empty model_name
.
Error raised: FileNotFoundError: [Errno 2] No such file or directory
Material
Google Colab
Suggestions
Change
# TODO: Specify file name for model and save the model to file
model_name = ""
by
# TODO: Specify file name for model and save the model to file
model_name = "ppo-LunarLander-v2"
or
# TODO: Specify a non empty file name for model and save the model to file
model_name =
simoninithomas commented
Hey, thanks for pointing this out ๐ค. I'm adding it to this month update
simoninithomas commented
Updated thanks again ๐ค