huggingface/llm-vscode

BUG: LLM-vscode breaks core VSCode keybindings

FrenchBen opened this issue · 4 comments

FrenchBen commented

surprised that no issue has been created for this

cmd+shift+L is one of the core bindings for VSCode, allowing a user to quickly "Select all occurrences of current selection" via editor.action.selectHighlights ref: https://code.visualstudio.com/docs/getstarted/keybindings

Why is llm-vscode overriding this thus breaking a core function?

llm-vscode/package.json

Line 229 in c9e1faf

"command": "editor.action.inlineSuggest.trigger" 

{
  "key": "cmd+shift+l",
  "command": "editor.action.inlineSuggest.trigger"
},

If the same keybinding is to be preserved, I would suggest adding some context: https://code.visualstudio.com/api/references/when-clause-contexts

github-actions commented

This issue is stale because it has been open for 30 days with no activity.

McPatate commented

Hello, I had no idea this binding was used for something else, this shortcut is legacy code. You can always change it if it doesn't suit you.
I'll check to change the value to something that doesn't conflict when I have some time.

github-actions commented

This issue is stale because it has been open for 30 days with no activity.

FrenchBen commented

Updated the code to use a less-common shortcut, and still preserve the original VSCode one.

  • 👍1