hughbris/grav-plugin-pushy

Internationalise strings in the UI

Closed this issue · 5 comments

PHP/Twig parts are a straightforward task, not sure if there's an elegant way to achieve this in JS/TS.

UI strings that are being set using ts/js, can also be stored inside translations.yaml. Translations of relevant UI strings can be collected inside PHP and transformed into a map of key/value pairs, which can be injected into ts/js using the Asset Manager. In ts/js, the map can be read and used to create dynamic output.

Thanks, I've done this plenty on the server side. Keen to see exactly how that all works in TS, but I don't see this as urgent. I added the issue as a placeholder for this task.

If you are keen (generally you are, @pamtbaau!), I prefer to merge the hughbris/issue11-git-library branch into develop first. I think most of my checking is done so shouldn't take me long :)

I haven't started refactoring TS yet... :-) I'll wait until develop is leading.

May I presume you've tested my PR about handling renamed files?

I haven't started refactoring TS yet... :-) I'll wait until develop is leading.

:P

May I presume you've tested my PR about handling renamed files?

Yup, thought you would have got a notification: #28.

Ref PR #30