hughsie/colord

Alarm Code Context

Opened this issue · 1 comments

doctormo commented

I'm reading through lcms2 to try and get things working and I notice that this code:

colord/lib/colord/cd-icc-utils.c

Line 98 in d0c5a29

cmsSetAlarmCodes (alarm_codes);

Should not work, if lcms2 uses contexts to store the alarm codes. But I find it unlikely that colord has a non-functioning gamut checker, so I'm not sure what to make of that.

Expected code:

cmsSetAlarmCodesTHR(cd_icc_get_context (icc), alarm_codes);
hughsie commented

But I find it unlikely that colord has a non-functioning gamut checker

I know it used to work, but I've not used that code in anger for many years.

cmsSetAlarmCodesTHR(cd_icc_get_context (icc), alarm_codes);

That looks much better entirely -- can you do a PR please.