Converters don't nest - can't handle .yml.gz

Question

Converters don't nest - can't handle .yml.gz

Closed this issue 6 years ago · 4 comments

libxmlb assumes the result of a gzipped file is XML, instead of checking the MIME type of the decompressed data. This means that .yml.gz files can't be handled by the converter.

robert-ancell commented 6 years ago

#14

Answer 1 · 2019-02-22T20:08:31.000Z

Got a patch handy? I'm just on PTO. Thanks.

Answer 2 · 2019-02-23T08:30:19.000Z

I will attempt to write one but haven't started yet. I figure the best thing is to re-check the mime type after a gzip decode.

Answer 3 · 2019-02-27T14:41:28.000Z

Okay, I've had a go at this too; I took what you did and rewrote it -- there is a proper context object we can extend in the future if we need to now. I've also pushed a wip/hughsie/XbBuilderSource-adapter branch in gnome-software which uses this new API -- feedback very welcome.