hughsie/libxmlb

why disable msvc?

Closed this issue · 1 comments

Hi,

I'm trying to build this project in Windows, with MSVC, but the code disabled it.

libxmlb/meson.build

Lines 89 to 91 in 4393955

if cc.get_id() == 'msvc'
error('MSVC is not supported as it does not support __attribute__((cleanup))')
endif

I checked the code and found that __attribute__((cleanup)) is not used in the source code, so why disable msvc?

I checked the code and found that __attribute__((cleanup)) is not used in the source code, so why disable msvc?

It is, any g_auto/g_autoptr macro makes use of it. Ideally build with gcc or clang instead, MSVC is a huge nightmare to work with with projects like this.