hugoduncan/criterium

ZIGNOR implementation probably has a bug

nilern opened this issue · 0 comments

This code has no effect because for is lazy and its result is not being used here. Without digging into the math I can't tell whether it is a bug.

If it indeed is a bug I would suggest replacing the for with

(dotimes [i c]
  (let [j (int i)]
    (aset s-adzigr j (/ (aget s-adzigx (inc j)) (aget s-adzigx j)))))

(Incidentally, the Integer type hint also has no effect so I removed that.)

If this is not a bug the for can just be removed as dead code.