Finer control on the duration/significance of criterium runs
davidsantiago opened this issue · 5 comments
As discussed in issue #8, it would be helpful to be able to control more finely the amount of time criterium runs benchmarks.
The gap between "quick" and "full" can be enormous. Having more ways available to pinpoint the statistical sampling parameters in criterium would really help in making it a tool you can run to understand your code's performance changes without slowing you down too much. I have some benchmarks that take over a second to run a single iteration, while others will run thousands and thousands of times in a benchmark run due to the minimum time requirements. Being able to independently set "minimum runs", "maximum runs", "minimum time", "maximum time" parameters would be great. Or at least having a few more levels between quick and full. Or even better, break out the independent parameters and then give helpful names to a few stock configurations for convenience.
I think the suggestions by @davidsantiago would be helpful.
@hugoduncan Are you suggesting that we read over those papers to get ideas on how to expose additional tuning parameters? Are you saying more? Perhaps it is not clear on how to do so?
👍 to @davidsantiago's suggestions.
I've been playing with perforate, and was wanting to start using it to get a rough idea of performance across multiple services.
Whilst I appreciate criterium's efforts to support micro benchmarking on the JVM, it seems that perforate even with --quick is doing too many runs for me (e.g. when benchmarking an operation that normally takes 10 minutes), in some circumstances just one or two runs are probably enough for some tests - so being able to configure this flexibly through criterium and then exposing it to perforate would be useful.
I appreciate that perhaps this is a different usecase, but having a crude sledgehammer to hard code the number of test runs would be really useful.
A way to know how long we allow the benchmark to run at most would be useful. Sometimes I start a benchmark on a function that takes 1 or 2 second to run and criterium runs to a point that I don't even have the patient to wait for. While other times, it takes only a few second to finish.
So if there was a way to say, run at most 10 second, and do your best to achieve reliable results within that time frame, it would be a great feature.