humanmade/aws-ses-wp-mail

Update AWS sdk as its out of date.

Closed this issue · 9 comments

andrewmclagan commented

count(): Parameter must be an array or an object that implements Countable in /var/www/wp-content/plugins/aws-ses-wp-mail/lib/aws-sdk/GuzzleHttp/Handler/CurlFactory.php on line 67

tareiking commented

Yo @andrewmclagan - long time (Tripleshot Creative Brisbane days long).

@joehoyle what's typically involved in updating the AWS SDK for this library? I can happily draft an update PR, but unsure what / if we need any feature testing during the process for this.

  • 👍1
joehoyle commented

@tareiking you'd bump https://github.com/humanmade/aws-ses-wp-mail/blob/master/composer.json and then copy vendor to lib, that's the most of it. As it happens, we don't use the bundled version ala https://github.com/humanmade/aws-ses-wp-mail/blob/master/inc/class-ses.php#L200 so I think that's why we haven't seen this.

andrewmclagan commented

@tareiking hey man! How are you? Here are you these days!?

hisham commented

Any update on this? Still occurring.

rmccue commented

@joehoyle should we copy over the S3 Uploads build script?

joehoyle commented

@rmccue yeah sounds like a good idea.

roborourke commented

The bundled copy of the SDK was removed in #41 so closing this out. We should loosen the composer.json version constraint though to ^3.x

roborourke commented

Ok that PR was ages before this ticket, reopening!