Since update to 1.16.0, bullet and numbered lists have major display issue
Closed this issue · 10 comments
Here is what it looks like in the Edit window:
Here is what it looks like when displayed:
The problem exists even with HumHub theme. Everything was fine prior to updating. The other issue I noticed that when editing and clicking on the right side of a sub-item to move the cursor to that area, it does not respond to the click unless you click just to the immediate right of the bullet. This behavior did not exist before.
I found that if I turned this off in dev mode, it fixes the display issue:
What is the right way to permanently fix this?
Another issue that DID exist before and still exists is this: When the cursor is at a particular location that you want to change to bullet/numbered list, and you click on bullet/numbered list icon in toolbar, the focus changes to toolbar and you must click again on the line you just changed to bullet/numbered list in order to keep typing the list. It would be nice if the focus did not change, and the cursor stayed where you clicked on toolbar.
HumHub Version: 1.16.0
PHP: 8.3.4
@luke- I also have this issue on latest develop branch, even after rebuilding the community theme.
@yurabakhtin Didn't you fix something here recently?
@yurabakhtin Didn't you fix something here recently?
@luke- Yes, it was broken here by me.
I have fixed in new PR humhub/humhub#7089:
before fix:
after fix:
Another issue that DID exist before and still exists is this: When the cursor is at a particular location that you want to change to bullet/numbered list, and you click on bullet/numbered list icon in toolbar, the focus changes to toolbar and you must click again on the line you just changed to bullet/numbered list in order to keep typing the list. It would be nice if the focus did not change, and the cursor stayed where you clicked on toolbar.
Do you mean the issue so the list buttons are hidden when we click to a list element like on my video below?
list.mp4
@yurabakhtin Thanks.
Fix will be avaiable with HumHub 1.16.1
Another issue that DID exist before and still exists is this: When the cursor is at a particular location that you want to change to bullet/numbered list, and you click on bullet/numbered list icon in toolbar, the focus changes to toolbar and you must click again on the line you just changed to bullet/numbered list in order to keep typing the list. It would be nice if the focus did not change, and the cursor stayed where you clicked on toolbar.
Do you mean the issue so the list buttons are hidden when we click to a list element like on my video below?
list.mp4
No, I'm saying that when you click on the icon to enable list or indent, the cursor moves away from the line that it was on before you click in the toolbar. Then you have to scroll down and click on that line again to keep typing on that same line.
No, I'm saying that when you click on the icon to enable list or indent, the cursor moves away from the line that it was on before you click in the toolbar. Then you have to scroll down and click on that line again to keep typing on that same line.
@WizWareTech Can you find the issue on my video below?
check-list.mp4
No, I'm saying that when you click on the icon to enable list or indent, the cursor moves away from the line that it was on before you click in the toolbar. Then you have to scroll down and click on that line again to keep typing on that same line.
@WizWareTech Can you find the issue on my video below?
check-list.mp4
Yes, I see it there. Is there a way to keep cursor in same location so when clicking the list icon in toolbar, you can immediately start typing without having to click location to put cursor again before starting to type?
Yes, I see it there. Is there a way to keep cursor in same location so when clicking the list icon in toolbar, you can immediately start typing without having to click location to put cursor again before starting to type?
@WizWareTech Thanks for the response, I got it, yes it seems only the list buttons have the unfocus issue, others doesn't move a cursor focus from the text editor to the toolbar. Ok, we will investigate this.
@luke- @WizWareTech PR humhub/humhub-prosemirror#148 for fix the unfocus issue.
I didn't find a reason why it was implemented here.