hunner/puppet-wordpress

install_url parameter is actually install_url_base

Opened this issue · 1 comments

The existing install_url parameter actually functions as the base of the URL where the wordpress tarball should be downloaded from. If I the wordpress package that I want to download is at http://example.com/my-wordpress.tar.gz, there's no way for me to specify that. I would expect that I could set install_url = http://example.com/my-wordpress.tar.gz and have that used. Instead, the install_url is actually used like:

${install_url}/wordpress-${version}.tar.gz

It's an API-breaking change, so will have to wait until your next major release, but the install_url parameter should be changed to install_url_base and another parameter should be added called install_url that allows a full URL to a tarball to be specified.

I'd be happy to submit a pull request for this, but it should probably wait until you're ready to tag a new major release.

Another thought I'd had from looking at the code base was to use nanliu/staging module to handle the download and deploy as I have in several other modules I've used and written. This is currently listed as a "Puppet Approved Module" but it also has a note that the 1.0.0 release is the last feature release and new work will go into nanliu/archive that will actually use types/providers rather than Execs. What I liked about the staging module is that it would work whether you had curl, wget or powershell available to download using.