use github actions for build and exclude bundles

[micuat]

potentially we can use github actions for automated build and exclude bundle.js files:
https://docs.github.com/en/actions/guides/building-and-testing-nodejs

[ojack]

Ohh this is a great idea! I haven't used this before. I think the one thing is that I would still like to make sure the bundled version is included when you download the repo.... just because many people like to download and run locally without understanding all of the build steps.

…

On Fri, Apr 9, 2021 at 8:26 AM Naoto HIÉDA ***@***.***> wrote: potentially we can use github actions for automated build and exclude bundle.js files: https://docs.github.com/en/actions/guides/building-and-testing-nodejs — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/ojack/hydra/issues/126>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFOVSNGLP7HGJ2THP7UTYDTH4MAZANCNFSM42VFZZHQ> .

[micuat]

I think you can point the default repo to the build result. I will check if I can set it up on my fork.

[micuat]

here's an example of action https://github.com/micuat/hydra/blob/actiontest/.github/workflows/node.js.yml

the repo with bundled files can be downloaded here https://github.com/micuat/hydra/actions/runs/734610316
(not sure if it's possible to make a permanent link for download)

[micuat]

In the end I think it's not worth using github actions because I think anyways users need to npm i when they download the repo, so why not doing npm run build-main as well. I don't know what is the best practice in this case but we can stick to having the bundle included and/or making a separate doc for deploying hydra on local server

[ojack]

Okay thank you for investigating this! I really go back and forth....I was thinking that some people use this without having node installed, but i just realized that that isn't possible as node is required to run the server anyway..... this makes me lean towards not including bundle. I definitely want to improve the build process as the current way of switching between bundle and bundle.min is terrible :)

…

On Mon, Apr 12, 2021 at 9:07 AM Naoto HIÉDA ***@***.***> wrote: In the end I think it's not worth using github actions because I think anyways users need to npm i when they download the repo, so why not doing npm run build-main as well. I don't know what is the best practice in this case but we can stick to having the bundle included and/or making a separate doc for deploying hydra on local server — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/ojack/hydra/issues/126#issuecomment-817935193>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFOVSMHW4NR5WTCPQTQQGLTIMLD5ANCNFSM42VFZZHQ> .