hyochan/dooboo-ui

dependency packages not installed automatically

Closed this issue · 3 comments

Einere commented

Describe the bug

When install dooboo-ui and use some components, error occured like below.

error: Error: Unable to resolve module react-native-vector-icons from /<some_path>/node_modules/dooboo-ui/Icon/index.js: react-native-vector-icons could not be found within the project or in these directories:
  node_modules/dooboo-ui/node_modules
  node_modules

I found missing package list

  • @emotion/react
  • @emotion/native
  • react-native-vector-icons

To Reproduce

  1. create example directory by run npx react-native init <project_name> --template react-native-template-typescript
  2. install dooboo-ui by running yarn add doooboo-ui
  3. import and use some component from dooboo-ui like Get Started
  4. run app by react-native start and react-native run-android
  5. unable to resolve module error occurred

Expected behavior

User don't need to install dependent packages, just installed automatically.
and don't occur "unable to resolve module error"

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: Google Pixel 41
  • OS: Android 11
  • dooboo-ui version : 0.1.23
  • npm version : 7.20.3
  • yarn version : 1.22.11

Additional context
Add any other context about the problem here.

hyochan commented

Thanks for trying out~! It looks like we can add to peerDependency in package.json. Would you like to give a PR for this?

In addition, we need postinstallation guide for iOS.
https://github.com/dooboolab/dooboo-native-ts#ios-setting-guide.

  • 👍1
luke-hanwook commented

I reproduce same process using physical device and have same issue (module resolve dependency error)

  • Device: galaxy 7 (Android 8)
  • OS: widnows 10
  • dooboo-ui version: 0.1.25
  • yarn version : 1.22.5

image

Einere commented

@luke-hanwook
I think it because #79 is already merged to master, but it hasn't released and deployed at NPM.
Please wait until release!

  • 👍1