hypercerts-org/hypercerts

[Graph] Add chainId to hypercerts ID in graph.

bitbeckers opened this issue · 3 comments

bitbeckers commented

Describe the feature you'd like to request

When I load a hypercert from the Graph based on the ID, I expect to also have the chainID in there. This makes it easy for users and developers to identify on what chain the hypercert lives

Describe the solution you'd like

https://hypercerts.org/app/view#claimId=0x822f17a9a5eecfd66dbaff7946a8071c265d1d07-16605439223374876078549217468062856950841344

Should become

https://hypercerts.org/app/view#claimId=[0xa]-0x822f17a9a5eecfd66dbaff7946a8071c265d1d07-16605439223374876078549217468062856950841344

or

https://hypercerts.org/app/view#claimId=[10]-0x822f17a9a5eecfd66dbaff7946a8071c265d1d07-16605439223374876078549217468062856950841344

Describe alternatives you've considered

.

Jipperism commented

I would prefer using 10 instead of 0xa.

Important to remember to update all entries in supabase tables that use claimIds.

bitbeckers commented

Let's also consider renaming it hypercertId because we already have claimId in the contracts and they're not the same