Connection leak

Question

Closed this issue 6 years ago · 7 comments

In certain cases I see connection leaks. I have a simple reproduction in: https://github.com/luben/repro-hyper

The behavior I observe:

with small requests everything works OK
with bigger request (e.g. 1 MiB payload) there is one connection per request leaked between the worker and the broker.
if I switch the worker/broker communication to HTTP/2 by uncommenting https://github.com/luben/repro-hyper/blob/master/src/bin/worker.rs#L16 - there is no more leaks.

Answer 1 · 2018-11-19T19:10:45.000Z

Thanks, I'll try out the repro locally.

Do you have any more details that would help me while I look? Is it consistently leaking the connection immediately, or only occassionally?

Answer 2 · 2018-11-19T19:44:09.000Z

It's consistently leaking with payloads of 1 MB. I have only tried and reproduced in on Linux.

Answer 3 · 2018-11-20T18:12:09.000Z

I have just added a negative example with src/bin/worker-non-stream.rs - if we .concat2() the body (i.e. not stream it back) there is no leak.

Answer 4 · 2018-11-20T18:56:34.000Z

Is the leak in broker, or in worker?

Answer 5 · 2018-11-20T21:04:25.000Z

The connection between the worker and the broker is not closed from both sides - verified with lsof.

Answer 6 · 2018-11-21T20:51:51.000Z

I see, it seems the dispatcher after having written the headers for some reason doesn't continue to do work, but stalls. I'll look more into it.

Answer 7 · 2018-11-22T00:49:32.000Z

I've published v0.12.16 with a fix for this, thanks for reporting and for the reproducible instructions!