hyperium/hyper

Re-enable tests for 0.13

seanmonstar opened this issue · 5 comments

seanmonstar commented

As part of merging #1836 (related to #1805), running the tests in CI was disabled. They should be re-enabled as we go along.

  • The --lib tests
  • benches directory
  • tests/client
  • tests/server
  • tests/integration
jakubadamw commented

The tests/client bit is done in #1881.

apiraino commented

@seanmonstar or anyone else, could you pls also add an example on how to use the Service and MakeService trait?

(I'm on Hyper 0.12 and having a hard time to figure that out. I'd be happy if for 0.13 that to be more discoverable).

thanks 👍

By the way: examples are of the essence for a library and I thank you so much for having written them! More of them, pls :-)

EDIT: https://stackoverflow.com/questions/57371130/hyper-0-12-x-implementing-service-for-a-struct

Mathspy commented

I think this is finally closed by #1882

weihanglo commented

@Mathspy
Not really. Some tests under src/client are still disabled. Most related to a new mock service implementations.

  • 👍1
seanmonstar commented

I'm going to close this, as almost all tests have been re-enabled. I've removed the warning about the missing tests in client/tests.rs, as re-writing them is rather tricky.

  • 🎉3