hyperjumptech/grule-rule-engine

go.mod module name in 1.14.0 release does not include github.com/.. prefix

twystd opened this issue · 2 comments

twystd commented

Describe the bug
The module name in release 1.14.0 has been changed from "github.com/hyperjumptech/grule-rule-engine" to "module grule-rule-engine".

To Reproduce

  1. Update from 1.13.x:go get -u github.com/hyperjumptech/grule-rule-engine
  2. Run go mod tidy
  3. go mod tidy reports an error:
github.com/hyperjumptech/grule-rule-engine/pkg
go: finding module for package github.com/hyperjumptech/grule-rule-engine/builder
go: finding module for package github.com/hyperjumptech/grule-rule-engine/ast
go: finding module for package github.com/hyperjumptech/grule-rule-engine/engine
go: found github.com/hyperjumptech/grule-rule-engine/ast in github.com/hyperjumptech/grule-rule-engine v1.14.0
go: found github.com/hyperjumptech/grule-rule-engine/builder in github.com/hyperjumptech/grule-rule-engine v1.14.0
go: found github.com/hyperjumptech/grule-rule-engine/engine in github.com/hyperjumptech/grule-rule-engine v1.14.0
go: found github.com/hyperjumptech/grule-rule-engine/pkg in github.com/hyperjumptech/grule-rule-engine v1.14.0
go: github.com/uhppoted/uhppoted-httpd/auth imports
	github.com/hyperjumptech/grule-rule-engine/ast: github.com/hyperjumptech/grule-rule-engine@v1.14.0: parsing go.mod:
	module declares its path as: grule-rule-engine
	        but was required as: github.com/hyperjumptech/grule-rule-engine

Expected behavior
go mod tidy should find and resolve the imports.

Additional context

Although it's possible to use a replace directive as a workaround, the standard seems to be to include github.com in the module path.

newm4n commented

Fixed in the latest release v1.4.1
Thanks a lot for pointing this out.

twystd commented

That was quick! Thank you :-)