hyperjumptech/monika

[SymonClient] When there is an unhandled error, Monika didn't send notifications to operator

Closed this issue · 3 comments

dennypradipta commented

This happened when there was an unusual alert query in Symon. The app crashed but there were no notifications sent to the operator regarding Monika is crashed. This is undetected because dockerized Monika has unless-stopped restart policy.

Monika should handle if it crashed, it should send notifications to operator

dennypradipta commented

@haricnugraha Might need to reconfirm to you: You said that when there is an error regarding some assertion, it stops Monika?

image

I just tried putting something weird in the assertion, run it both locally and dockerized, it didn't stop the container. Above is the screenshot of running it in Dockerized, without unless-stopped restart policy

haricnugraha commented

@haricnugraha Might need to reconfirm to you: You said that when there is an error regarding some assertion, it stops Monika?

image I just tried putting something weird in the assertion, run it both locally and dockerized, it didn't stop the container. Above is the screenshot of running it in Dockerized, without `unless-stopped` restart policy

Did you use main branch? If so, I've fixed it in pull request 1179.

dennypradipta commented

Ah, figures. It can be closed then.