ci(custom-checks): fix dependencies being inconsistent phase 10
Opened this issue · 1 comments
jagpreetsinghsasan commented
Description
As a developer, I want to fix the dependency versions being inconsistent across packages in Cacti.
Targeted packages:
packages/cactus-test-plugin-htlc-eth-besu-erc20 (This might be hard as we need to upgrade web3 from 1.x to 4.x)
packages/cactus-test-plugin-ledger-connector-besu (This might be hard for the reasons mentioned above)
packages/cactus-test-plugin-ledger-connector-ethereum (This might be hard for the reasons mentioned above)
packages/cactus-test-tooling (Lots of changes here)
Depends on #3612
Solution:
Run the script tools/custom-checks/check-dependency-version-consistency.ts with fix: true
, note down the changes for the above targeted packages
, stash and drop the changes, and proceed with fixing just those targeted packages.
Possible errors
- The package being dependent on other packages can lead to conflicts in those dependent packages. Even if those newly failing package tests occur, fixing those in this phase becomes important or else we will have broken code in repo.
To test this scenario, simply create a PR for this task fixing only the targeted packages and have a lookout on CI for any failing tests. If we have any failing tasks, we should fix them as a part of this task - The fix might involve breaking changes, and shall be reported in the PR
- For some dependencies, the suggest change might not be an exact version (due to it being the highest version among all packages), so instead of including the versions like
>=1.2.3
, fix the root package which has this sort of version and then include that in the conflicting package (a 2 way solution)
Acceptance Criteria
- The above targeted packages have all the dependency version inconsistencies fixed
- No new crashes are seen in CI
github-actions commented
This PR/issue depends on:
- #3612
By Dependent Issues (🤖). Happy coding!