`validatePortIdentifier` doesn't return false

[srdtrk]

Shouldn't this function return false if the loop assertion fails?

yui-ibc-solidity/contracts/core/26-router/IBCModuleManager.sol

Lines 116 to 147 in 49d88ae

	/**
	* @dev validatePortIdentifier validates a port identifier string
	* check if the string consist of characters in one of the following categories only:
	* - Alphanumeric
	* - `.`, `_`, `+`, `-`, `#`
	* - `[`, `]`, `<`, `>`
	*/
	function validatePortIdentifier(bytes memory portId) internal pure returns (bool) {
	if (portId.length < 2 || portId.length > 128) {
	return false;
	}
	unchecked {
	for (uint256 i = 0; i < portId.length; i++) {
	uint256 c = uint256(uint8(portId[i]));
	if (
	// a-z
	(c >= 0x61 && c <= 0x7A)
	// 0-9
	|| (c >= 0x30 && c <= 0x39)
	// A-Z
	|| (c >= 0x41 && c <= 0x5A)
	// ".", "_", "+", "-"
	|| (c == 0x2E || c == 0x5F || c == 0x2B || c == 0x2D)
	// "#", "[", "]", "<", ">"
	|| (c == 0x23 || c == 0x5B || c == 0x5D || c == 0x3C || c == 0x3E)
	) {
	continue;
	}
	}
	}
	return true;
	}

[bluele]

Thanks! We will fix it soon.