hyperledger/indy-shared-rs

Library name missing from error message

Closed this issue · 1 comments

In commit #2502647 lib_name was changed to lib_path in two places in wrappers/python/indy_credx/bindings.py. In the first instance, the code is preceded by:

lib_path = find_library(lib_name)
if not lib_path:

Since the if statement tests for no library returned from find_library, the value of lib_path will always be None within the if statement, resulting in the library name in the message always being None:

indy_credx.error.CredxError: Library not found in path: None

Note that in reference to the other place where lib_name was changed to lib_path in CredxErrorCode.WRAPPER, f"Error loading library: {lib_path}" -- there is the same code in indy-vdr/wrappers/python/indy_vdr/bindings.py. If the change is appropriate in this bindings.py, the same change could be made in the bindings.py file in the Indy VDR repository also.

Fix in PR #36