hyperoslo/Lightbox

Carthage broken because of the update in Imaginary

yspreen opened this issue · 9 comments

carthage update --platform iOS
*** Fetching Lightbox
*** Fetching Imaginary
*** Checking out Imaginary at "4.3.1"
*** Checking out Lightbox at "2.3.0"
*** xcodebuild output can be found in /var/folders/zx/vkw16gb963vbw6n8w_sgl_g40000gn/T/carthage-xcodebuild.cAzWRC.log
*** Downloading Imaginary.framework binary at "Imaginary — 4.3.1"
*** Building scheme "Lightbox-iOS" in Lightbox.xcodeproj
Build Failed
        Task failed with exit code 65:
        /usr/bin/xcrun xcodebuild -project /Users/user/Documents/proj/6tudio/ios-app/Carthage/Checkouts/Lightbox/Lightbox.xcodeproj -scheme Lightbox-iOS -configuration Release -derivedDataPath /Users/user/Library/Caches/org.carthage.CarthageKit/DerivedData/11.5_11E608c/Lightbox/2.3.0 -sdk iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/zx/vkw16gb963vbw6n8w_sgl_g40000gn/T/Lightbox SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in /Users/user/Documents/proj/6tudio/ios-app/Carthage/Checkouts/Lightbox)

This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/zx/vkw16gb963vbw6n8w_sgl_g40000gn/T/carthage-xcodebuild.cAzWRC.log
───────┬─────────────────────────────────────────────────
       │ File: Cartfile
───────┼─────────────────────────────────────────────────
   1 ‾ │ github "hyperoslo/Lightbox" ~> 2.3
───────┴─────────────────────────────────────────────────
───────┬─────────────────────────────────────────────────
       │ File: Cartfile.resolved
───────┼─────────────────────────────────────────────────
   1 ~ │ github "hyperoslo/Imaginary" "4.3.1"
   2   │ github "hyperoslo/Lightbox" "2.3.0"
───────┴─────────────────────────────────────────────────
3lvis commented

This project is currently unmaintained and broken under iOS 13.

3lvis commented

Any help would be appreciated

How is it broken under iOS 13? If you fix the Imaginary version to the old one, everything works fine

github "hyperoslo/Imaginary" == 4.2.0

#249 should fix this, have a look.

Just a clarification: Imaginary == 4.2.0 is the fix for users. I fixed the issue with the PR by adding the now missing library, making the workaround not necessary anymore!

Thanks for merging! Once a new release is out I'll close this 👌

3lvis commented

Release is out!

3lvis commented

This should be fixed now :)