hypertidy/anglr

dplyr 1L

mdsumner opened this issue · 6 comments

Why these old things coming up?

    DEL0(PATH0(silicate::minimal_mesh))
class       : DEL0
type        : Primitive
vertices    : 14 (2-space)
primitives  : 15 (2-space)
crs         : NA
Warning messages:
1: `group_indices_()` is deprecated as of dplyr 0.7.0.
Please use `group_indices()` instead.
This warning is displayed once every 8 hours.
Call `lifecycle::last_warnings()` to see where this warning was generated. 
2: The `...` argument of `group_keys()` is deprecated as of dplyr 1.0.0.
Please `group_by()` first
This warning is displayed once every 8 hours.
Call `lifecycle::last_warnings()` to see where this warning was generated. 
3: `distinct_()` is deprecated as of dplyr 0.7.0.
Please use `distinct()` instead.
See vignette('programming') for more help
This warning is displayed once every 8 hours.
Call `lifecycle::last_warnings()` to see where this warning was generated. 
4: `select_()` is deprecated as of dplyr 0.7.0.
Please use `select()` instead.
This warning is displayed once every 8 hours.
Call `lifecycle::last_warnings()` to see where this warning was generated. 

unjoin

 options(warn = 2)
> devtools::load_all(".")
Loading anglr
>     DEL0(PATH0(silicate::minimal_mesh))
 Error: (converted from warning) `group_indices_()` is deprecated as of dplyr 0.7.0.
Please use `group_indices()` instead.
This warning is displayed once every 8 hours.
Call `lifecycle::last_warnings()` to see where this warning was generated. 
> traceback()
21: doWithOneRestart(return(expr), restart)
20: withOneRestart(expr, restarts[[1L]])
19: withRestarts({
        .Internal(.signalCondition(cond, message, call))
        .Internal(.dfltWarn(message, call))
    }, muffleWarning = function() NULL)
18: warning(wrn)
17: doWithOneRestart(return(expr), restart)
16: withOneRestart(expr, restarts[[1L]])
15: withRestarts(muffleWarning = maybe_push_warning, {
        signalCondition(wrn)
        push_warning(wrn)
        warning(wrn)
    })
14: lifecycle::deprecate_warn("0.7.0", paste0(fun, "_()"), paste0(fun, 
        "()"), details = if (hint) "See vignette('programming') for more help")
13: lazy_deprec("group_indices", hint = FALSE)
12: dplyr::group_indices_(data, .dots = unjoin_cols)
11: unjoin_impl(tibble::as_tibble(data), group_cols, unjoin_cols, 
        key_col = key_col)
10: unjoin_.data.frame(v, V_names, key_col = key_col)
9: unjoin::unjoin_(v, V_names, key_col = key_col)
8: PATH.default(x)
7: silicate::PATH(x) at polygon-finder-for-triangles.R#5
6: extents(silicate::PATH(x)) at polygon-finder-for-triangles.R#8
5: extents.default(x) at polygon-finder-for-triangles.R#5
4: extents(x) at polygon-finder-for-triangles.R#56
3: path_triangle_map(x, RTri) at DEL0-model.R#207
2: DEL0.PATH0(PATH0(silicate::minimal_mesh)) at DEL0-model.R#84
1: DEL0(PATH0(silicate::minimal_mesh))

unjoin

image

silicate

image

also needed to ensure columns lined up for ARC bind_rows, and not mixing bind_rows(df, list) but bind_rows(df, bind_rows(list))

unjoin will be updated once silicate win binaries come through, this is the tail out of the verb_() days

fixed