Funds naming collision
Closed this issue · 1 comments
adairrr commented
If you have a parameter in a message called funds it collides with the funds that one can provide for the coins in the message.
Example:
pub enum AutocompounderExecuteMsg {
...
/// Join vault by depositing one or more funds
Deposit { funds: Vec<OfferAsset> },
}export interface AutocompounderInterface extends AutocompounderReadOnlyInterface {
...
deposit: (
{
funds,
}: {
funds: AnsAsset[]
},
fee?: number | StdFee | 'auto',
memo?: string,
funds?: Coin[]
) => Promise<ExecuteResult>
...
}I propose that we rename fee, memo, and funds to their underscored variants: _fee, _memo, and _funds.
pyramation commented
oh interesting! totally good idea
we can put it under a flag called underscoreMetaParams or something that makes sense