hyperxpro/Brotli4j

Version 1.9.0 has no platform-specific dependencies in pom

sinedsem opened this issue · 8 comments

Hi,

When I use version 1.8.0 it downloads correct native jar for my OS.

[INFO] --------------------------< com.example:mock >--------------------------
[INFO] Building mock 0.0.1-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
Downloading from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/brotli4j/1.8.0/brotli4j-1.8.0.pom
Downloaded from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/brotli4j/1.8.0/brotli4j-1.8.0.pom (4.1 kB at 13 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/brotli4j-parent/1.8.0/brotli4j-parent-1.8.0.pom
Downloaded from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/brotli4j-parent/1.8.0/brotli4j-parent-1.8.0.pom (6.3 kB at 76 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/native-osx-aarch64/1.8.0/native-osx-aarch64-1.8.0.pom
Downloaded from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/native-osx-aarch64/1.8.0/native-osx-aarch64-1.8.0.pom (2.9 kB at 36 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/natives/1.8.0/natives-1.8.0.pom
Downloaded from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/natives/1.8.0/natives-1.8.0.pom (3.6 kB at 42 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/brotli4j/1.8.0/brotli4j-1.8.0.jar
Downloading from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/native-osx-aarch64/1.8.0/native-osx-aarch64-1.8.0.jar
Downloaded from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/brotli4j/1.8.0/brotli4j-1.8.0.jar (41 kB at 230 kB/s)
Downloaded from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/native-osx-aarch64/1.8.0/native-osx-aarch64-1.8.0.jar (435 kB at 2.0 MB/s)
[INFO] 
[INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ mock ---

But version 1.9.0 doesn't.

[INFO] --------------------------< com.example:mock >--------------------------
[INFO] Building mock 0.0.1-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
Downloading from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/brotli4j/1.9.0/brotli4j-1.9.0.pom
Downloaded from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/brotli4j/1.9.0/brotli4j-1.9.0.pom (2.9 kB at 9.0 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/brotli4j-parent/1.9.0/brotli4j-parent-1.9.0.pom
Downloaded from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/brotli4j-parent/1.9.0/brotli4j-parent-1.9.0.pom (6.8 kB at 77 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/brotli4j/1.9.0/brotli4j-1.9.0.jar
Downloaded from central: https://repo.maven.apache.org/maven2/com/aayushatharva/brotli4j/brotli4j/1.9.0/brotli4j-1.9.0.jar (43 kB at 359 kB/s)
[INFO] 
[INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ mock ---

Looks like there is no dependencies declared in 1.9.0 pom.

Which maven command are you using?

Which maven command are you using?

mvn clean install to build my project, as usual.

I don't have M1 at my disposal. Would you mind debugging at your end?

@hyperxpro ,
Why did you remove profiles from pom in f15e88d#diff-afb191a836a47d90100a4382e45f325dcb4d3a2a918c3b1dba6c0d5afbb39a03 ?
I think this is the issue.

Good question... I actually don't know why I did that. Maybe I tried to test if that would resolve the issue with circular build deps and forgot to add it back in. I'll take a closer look

Do you have any clue? I will be pushing a release this weekend. So It'd be great if we could fix this in it.

s-rwe commented

Nice to see this, I was also wondering why I had to add the native dependency manually in a project, after updating to 1.9.0 :)