hypery2k/tvml-kit-livereload

Socket.io-client error + undefined filename

hhumphrey-dazn opened this issue · 4 comments

I'm coming across a couple of issues and just wanted to check before opening a PR. First when I run this within my tvml project I get

TypeError: undefined is not an object (evaluating 'Object.prototype')

This seems to stem from socket.io-client v1.4+:

socketio/socket.io#2381

Reverting back to 1.3.7 fixes the issue.

Also filename is missing from the method readFileContent, easily fixable and I'm happy to open a new PR if preferred.

would be great if you fill a PR as I'm currently busy with other stuff

I've published version 0.3.0

Thank you! This didn't include #7 any particular reason why?

sorry my fault. Will fix this