hyunsupul/aesop-core

Video component bug

Closed this issue · 1 comments

peiche commented

In ai-core.css, there is this line:

.aesop-video-component .self .mejs-overlay-button {
  margin-top: 25% !important;
}

As far as I can tell, this doesn't do anything but break where the self-hosted video's large centered play button appears.

This is what it looks like with this line enabled (note the inspector highlighting):

1499315021808screensave

And this is what it looks like with this line removed:

1499315284251screensave

Unless someone can tell me what specific use-case this line of CSS targets, I see no reason why it cannot be removed. (We should avoid using !important in any case, especially so that theme developers (ahem) don't have to enter an arms race of ever higher specificity and overrides.)

hyunsupul commented

Hi Paul, I am not sure about the reason that line was inserted. I will try to fix it in the next release.

  • 👍1