Idea - Fix Types - Tag Id can be null ( In case allowNew: true )
rusikf opened this issue · 2 comments
rusikf commented
Expected behaviour
export interface Tag {
id: string | number | null;
name: string;
disabled?: boolean | undefined;
}
Current behavior
The tag cannot be null. But it's possible if you add a new tag with allowNew: true
option. Of course, you can add a fake id inside onAddition
for it, but it will be useful to distinguish between new and existing tags.
Additional context
i-like-robots commented
Thanks for the report but I'm afraid the type definitions you linked to are not maintained by me and I'm not aware they're associated with anybody who has helped me to maintain this repo either.
The next major version of the component has been authored in TypeScript so includes its own type definitions. That's currently in beta and I plan to release it fully quite soon.
rusikf commented
Thank's for the fast response and clarification! 👍