i-love-flamingo/flamingo

Opencensus Module sets X-Correlation-Id even if already present

nico-i opened this issue · 1 comments

Description

Currently the open census module adds a correlation id header and value to every HTTP request. This leads to problems in our project as we already use the X-Correlation-Id header in other contexts throughout our services.

Proposed solution

To deal with this issue I suggest to modify the corresponding module.go to only set the X-Correlation-Id header if it isn't already present and to instead use the existing X-Correlation-Id value if it is.

Acknowledgements

I know that the open census module has since been deprecated but as we are currently dealing with this problem and the ETA for open census' replacement is yet to be determined, I think taking on this issue is still viable.

closed by #310