iCepa/Tor.framework

Invalid CFBundleVersion number

Closed this issue · 3 comments

Jasonvdb commented

Apps using version 400.6.3 are unable to be submitted to the app store because of an invalid number for the CFBundleVersion.

Screenshot 2020-03-06 at 08 17 29

Seems to be a problem with the method of incrementing the version in https://github.com/iCepa/Tor.framework/blob/master/Tor/version.sh

Have a suspicion the bug came in with this commit 6b0c7ed but don't understand it's reason well enough to make a change.

Fonta1n3 commented

I am getting this too after updating... thank goodness you raised this issue. I was going insane.

tladesignz commented

  1. The mentioned commit made it possible to actually build on a non-US-localized system. Nothing else.

  2. Problem was, that I used a time slightly in the future here when I did the release build:

    Tor.framework/Tor/version.sh

    Line 24 in 8fc455b

    TOR_BUNDLE_SHORT_VERSION_DATE="2020-02-24 11:30:00 GMT"

    That leads to a negative number:

    Tor.framework/Tor/version.sh

    Line 36 in 8fc455b

    MINUTES_SINCE_DATE=$(( $(( ${SECONDS_FROM_EPOCH_TO_NOW}-${SECONDS_FROM_EPOCH_TO_DATE} ))/60 ))

I re-built and uploaded the release anew. Going to fix the script.

Re-download Tor.framework with Carthage or Cocoapods and you should be good!
Make sure to clear Carthage's caches:

project$ rm -rf ~/Library/Caches/org.carthage.CarthageKit
project$ rm -r Carthage

(or analogue if you use Cocoapods)

Thanks for catching this and sorry for the inconvenience!

  • 🚀1
Jasonvdb commented

Awesome thanks for the quick fix!

  • 👍1