Rename plugin class

Question

Rename plugin class

Closed this issue 7 years ago · 6 comments

Hi,

According to Webpack team:

3rd party Plugin names should be foo-webpack-plugin for pkg name and FooWebpackPlugin for class

The package will not be renamed for now but we have to change plugin class.
It should keep compatibility with previous class name.

Task list

Change documentation
Update test case
Update class name

If you find another side effect, do not hesitate to correct it

Thank you

Answer 1 · 2017-03-04T01:29:48.000Z

If you are still looking for a contributor for this I would love to help out. I found this through Twitter Your First PR.

Answer 2 · 2017-03-04T08:33:21.000Z

Hi @Phinneas,

Thank you for helping us !
Of course, I always looking for project contributors. For this issue, nobody has started to work on, so, please feel free to make a pull request with your enhancement 😉

I hope we'll work together on great stuffs !

Welcome

Answer 3 · 2017-03-10T12:15:50.000Z

Hi @Phinneas,

do you need some help ?

Answer 4 · 2017-03-12T22:07:23.000Z

I may. I'm entry level to coding but I want to refine my chops beyond just class work. And to be honest I have, as of yet, had much time to work on this. If you give me hint on how to start I can take it from there. Open sesame.

…

On Mar 10, 2017, at 4:15 AM, Sebastien Correaud ***@***.***> wrote: Hi @Phinneas, do you need some help ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Answer 5 · 2017-03-14T09:09:34.000Z

Hi,

I'm glad to hear that you're a "student" and you already want to contribute to help the community ❤️

So, I'll give you some tricks to resolve this issue.
For now, we have class ContentReplacer in the index.js file

We need to have a class name ContentReplacerWebpackPlugin so you can easily change class name.

You have to replace all constructor in tests

After that, make a commit, a pull request and I'll give you more advice to complete the issue

Thank you very much @Phinneas

Answer 6 · 2017-03-15T00:56:32.000Z

Sweet. thank you

…

On Tue, Mar 14, 2017 at 2:09 AM, Sebastien Correaud < ***@***.***> wrote: Hi, I'm glad to hear that you're a student and you already want to contribute to help the community ❤️ So, I'll give you some tricks to resolve this issue. For now, we have class ContentReplacer in the index.js file <https://github.com/iGitScor/webpack-content-replacer-plugin/blob/master/index.js> We need to have a class name ContentReplacerWebpackPlugin so you can easily change class name. You have to replace all constructor in tests <https://github.com/iGitScor/webpack-content-replacer-plugin/tree/master/test> After that, make a commit, a pull request and I'll give you more advice to complete the issue Thank you very much @Phinneas <https://github.com/Phinneas> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA-dYhiLyyPqtvCRT2lPP5stnZ9GwGLyks5rlllOgaJpZM4MQtio> .