iRaul/pushy-buttons

Why not Button elements?

Closed this issue · 2 comments

marcysutton commented

I saw the README promotes using <a class="btn btn--lg btn--blue" href="#">Button</a>. Any reason why you're using links without hrefs when the whole concept is about buttons?

I would recommend promoting the <button> element with classes since the push-button design will lead users to expect them to be buttons, which are triggered with the space bar as opposed to the enter key.

iRaul commented

No reason. 😃

Thanks for suggestion. You can contribute with this change if you want 😉

iRaul commented

Changed to <button> element.

  • 🎉1
  • ❤️1