Suggestion: Decode values
Justin-isec opened this issue · 4 comments
Hey guys,
Currently using a slightly out-of-date copy, so maybe this is already done in a newer release.
When grabbing return values, many have known meanings. For example, if SecItemCopyMatching returns -25300, it means that the value wasn't found.
Another example: SecItemAdd with attribute pdmn=aku corresponds to a specific protection type (I think this is only when unlocked, this device only)
It would be cool to have these baked into introspy somehow so the user doesn't have to know/look up these values.
The python client does this. We cld do it in the swizzled function as well though... It wld make reading the logs easier.
On Mar 6, 2013, at 19:21, Justin-isec notifications@github.com wrote:
Hey guys,
Currently using a slightly out-of-date copy, so maybe this is already done in a newer release.
When grabbing return values, many have known meanings. For example, if SecItemCopyMatching returns -25300, it means that the value wasn't found.
Another example: SecItemAdd with attribute pdmn=aku corresponds to a specific protection type (I think this is only when unlocked, this device only)
It would be cool to have these baked into introspy somehow so the user doesn't have to know/look up these values.
—
Reply to this email directly or view it on GitHub.
Yeah it would make reading the logs much easier.
But I can't decide whether we should keep the traced call data as "pure" as possible when storing it into our DB, in case we want to plug that data into a different tool or something.
I think we should leave interpretation of these values to the client. The console logging is useful but not the intended method for analysis -- primarily it is just informational.
Agreed