Loss of data after merge

Question

Loss of data after merge

Opened this issue 9 months ago · 5 comments

Here testing stuff with 1.1.0.
settings.core.json
settings.ui.json
settings.shell.json
settings.python.json

After merge I get this final json:
settings.json

emeraldwalk.runonsave is missing in the final JSON. Also space formatting is not preserved:

  "emeraldwalk.runonsave": {
    "commands": [
      {
        "match": "\\.vscode/settings\\.(.+)\\.json$",
        "cmd": "sed '/^\\s*\\/\\//d' ${workspaceFolder}/.vscode/settings.*.json | sed -z 's/,\\s*\\([]}]\\)/\\1/g' | jq -s 'reduce .[] as $item ({}; . * $item)' > /tmp/settings.json && mv /tmp/settings.json ${workspaceFolder}/.vscode/settings.json"
      }
    ]
  },

vs

  "commands": [
  {
    "match": "\\.vscode/settings\\.(.+)\\.json$",
    "cmd": "sed '/^\\s*\\/\\//d' ${workspaceFolder}/.vscode/settings.*.json | sed -z 's/,\\s*\\([]}]\\)/\\1/g' | jq -s 'reduce .[] as $item ({}; . * $item)' > /tmp/settings.json && mv /tmp/settings.json ${workspaceFolder}/.vscode/settings.json"
  }
],

Answer 1 · 2024-01-15T15:08:42.000Z

Hi, thank you for trying out the extension! I'll try to fix these issues soon. I can see .shell.json and .python.json didn't make it into the final cut at all? Did it report an error before that happened?

Answer 2 · 2024-01-15T15:27:58.000Z

Didn't get any errors whatsoever...

Answer 3 · 2024-01-15T15:29:54.000Z

Final working result should be the same output as is produced by run on save with this config:

  "emeraldwalk.runonsave": {
    "commands": [
      {
        "cmd": "sed '/^\\s*\\/\\//d' ${workspaceFolder}/.vscode/settings.*.json | sed -z 's/,\\s*\\([]}]\\)/\\1/g' | jq -sS 'reduce .[] as $item ({}; . * $item)' > /tmp/settings.json && mv /tmp/settings.json ${workspaceFolder}/.vscode/settings.json",
        "match": "\\.vscode/settings\\.(.+)\\.json$"
      }
    ]
  },

Answer 4 · 2024-01-15T15:31:45.000Z

Admittedly, my config is much simpler, so i didn't encounter any issues. I'll strip the values out of the files you posted and add them to the test cases.

Answer 5 · 2024-01-15T15:31:46.000Z

Here are more test cases
settings.json
settings.core.json
settings.standards.json
settings.ui.json
settings.optimization.json

(settings.json is generated correctly with my script)