SBGN brick: Multimerization
Closed this issue · 6 comments
ugurdogrusoz commented
As described in the related document and also shown here, let's implement multimerization. Notice that, unlike previous ones, we should let the user choose the type of regulator (stimulation or inhibition).
msalihaltun commented
9ea384d implements multimerization.
ugurdogrusoz commented
Some improvements:
- 1. Put the type of regulation after multimer checkbox and count (leave some space in between) as regulator name and type belong to the regulating node, whereas regulation type is related to the edge from the regulator node to the process.
- 2. When multimer cardinality is below 2, we should not display any cardinality on the input edge at all.
- 3.
When orientation is top-to-bottom, multimer cardinality is too close to the input macromolecule and blocked by it.
msalihaltun commented
ugurdogrusoz commented
OK. If the location of the cardinality is determined automatically, this is a separate issue. Please create a new issue for this to fix later.
ugurdogrusoz commented
msalihaltun commented
That's strange. It all goes in the same row for me and pretty much everything is fixed length. Is it the same for association brick as well?