iVis-at-Bilkent/newt

SBGN brick: Multimerization

Closed this issue · 6 comments

As described in the related document and also shown here, let's implement multimerization. Notice that, unlike previous ones, we should let the user choose the type of regulator (stimulation or inhibition).

9ea384d implements multimerization.

Some improvements:

  • 1. Put the type of regulation after multimer checkbox and count (leave some space in between) as regulator name and type belong to the regulating node, whereas regulation type is related to the edge from the regulator node to the process.
  • 2. When multimer cardinality is below 2, we should not display any cardinality on the input edge at all.
  • 3. When orientation is top-to-bottom, multimer cardinality is too close to the input macromolecule and blocked by it.

I think the edge cardinality when vertical is about how we render the cardinality inside sbgnviz.js. I can see the same problem in the daily deployment.

image

OK. If the location of the cardinality is determined automatically, this is a separate issue. Please create a new issue for this to fix later.

  1. I don't know if this is intentional but I think all can go in a single row:
    Screenshot 2021-05-24 135410

That's strange. It all goes in the same row for me and pretty much everything is fixed length. Is it the same for association brick as well?