iXit/Mesa-3D

Stalker black weapon regression.

Closed this issue · 3 comments

iiv3 commented

This problem appears after applying the constant compacting patches, that are still not in master.
Binocular and pistol appear very dark, while at least the pistol is bright and shiny without the patches.

Uploading a trace to the ftp.

For the record, there was already one regression with Stalker games, that caused crash at load. But that was just fixed in Ixit/Mesa.

iiv3 commented

To help with the bug hunting, I think that in frame 800, the gun is drawn by call 1045503.
It's a bit tricky to find, since it draws over the old render_target, but I see it drawn in the depth buffer and it definitely uses DXT5 texture of a gun for the call.

The strange thing is that the shader is quite simple and I don't see it using any constants...

I reverted the FETCH4 & DF24 commits, but the bug remained. I'll try bisect, in case the bug is not in the const compact code.

iiv3 commented

The bisect landed me on

commit 85a332246b8c60f44c1eb2c2924a6d49612b0edd
Author: Axel Davy <davyaxel0@gmail.com>
Date:   Sun Jan 13 22:25:46 2019 +0100

    st/nine: Compact pixel shader key
    
    Compact the shader key to make room for new
    elements.
iiv3 commented

The new reworked commit seems to fix the issue.

commit 92d51ae620462c45ec17508cce7d249cd4adfb6f
Author: Axel Davy <davyaxel0@gmail.com>
Date:   Sun Jan 13 22:25:46 2019 +0100

    st/nine: Compact pixel shader key
    
    Compact the shader key to make room for new
    elements.