iamkroot/trakt-scrobbler

[RFC] Issues about pinned setuptools

ahmubashshir opened this issue · 3 comments

ahmubashshir commented

As far as I've seen, we don't depend on setuptools package in any way (is it even needed when we're using pypoetry?)

iamkroot commented

I do remember adding it manually because something broke after we moved from pipenv. Will take a look at the git history and see.

iamkroot commented

Hey @ahmubashshir I just went through #257. Turns out we need setuptools because babelfish (which itself is a dep of guessit) wants pkg_resources that hasn't been shipped with Python for a long time. Once Diaoul/babelfish#46 is fixed, we can remove setuptools from our deps.

  • 👍1