iamkroot/trakt-scrobbler

[Feature Request] add `send_immediately` to send "finished" status to trakt after watching >=80% to fix #202

soredake opened this issue · 1 comments

If this option is added, #202 can be considered as fixed, as finished state will be sent before changing file.

My main hesitancy with this is how to deduplicate the scrobbles. If we've already added it to history at 80% and then continue watching we need to remember not to scrobble again. And this needs to be persisted across many plays (you can close a file at 85%, come back tomorrow and play the rest of it.) Makes the logic a lot more complicated than what it is today.

If someone is willing to contribute with a simple PR, I'm willing to review.