StateChange subclass not part of upstream pysignal project
knight-of-ni opened this issue · 3 comments
This is part of the open package review on redhat, to get ouimeaux added to the offical Fedora repos. https://bugzilla.redhat.com/show_bug.cgi?id=1839242
Follow along with me here...
During the review, it was noticed that pysignals was bundled with ouimeaux. I have to unbundle it into it's own package. This was done and a request for a new pysignals package was created:
https://bugzilla.redhat.com/show_bug.cgi?id=1848049
That has lead to the discovery that the bundled pysignals has a custom subclass StateChange, which is not part of the upstream pysignals project.
This subclass was added in commit d2fc935 .
Technically, I could just patch d2fc935 into the new pysignals rpm package.
However, I think it would be more appropriate to move the subclass definition out of dispatcher.py to somewhere else in ouimeaux project folder. Let me know your thoughts on this. I am not convinced one way or the other at the moment.
I just thought of a hidden option number 3 - email the author of pysignals and ask for commit access to the (dead) project, with the intent of creating a new release merging py3 compat, statechange subclass, and any other needed goodies.
I'll let you know if I get a response.
@iancmcc Good news. The author of pysignals granted me commit access to the project. I will be generating a new release soon. Feedback can be left here:
theojulienne/PySignals#4
Closing, as all changes are now part of the pysignals project