ianmcnally/react-input-completion

Consider moving `react-dom` into dependencies

ctumolosus opened this issue · 5 comments

ctumolosus commented

Otherwise it won't be installed when required by another package and your package depends on it, papalote (sorry couldn't resist).

ianmcnally commented

😁

ianmcnally commented

get a pull request up in here

ianmcnally commented

also, wouldn't that make sense as a peerDep?

ianmcnally commented

1.0.1 lists react-dom as a peer dependency 😬

PAPA-LOTE 👏👏 ... 👏👏👏