ianyepan/vscode-dark-plus-emacs-theme

Add config to helm-ls-git-added-modified-face

zw963 opened this issue · 2 comments

zw963 commented

Please check following discuss:

emacs-helm/helm#2548

Following blue color is really hard to read.

image

In fact, many other themes add config to this, e.g. leuven, color-theme-sanityinc-tomorrow etc.

e.g. it really nice to use same color for M and AM, like sanityinc-tomorrow.

image

Or monokai theme

image

i really love this vscode emacs theme, except missing this config.

thank you.

zw963 commented

Helm config it default face to a better color, this issue get fixed now, although, make this configable in theme still isn't a bad idea.

Thanks @zw963 for bringing this up! I'm glad that the issue is fixed by Helm config. Personally, I use ivy/counsel instead of Helm, so I can't say I'm familiar with the issue.

...make this configurable in theme still isn't a bad idea.

If you could provide a PR, I'd be more than happy to merge it. Cheers!