Disable Code Coverage needed for xCode 9 - Carthage Compatibility

[zirinisp]

when submitting to App Store I am getting the following warning:

Invalid Bundle - Disallowed LLVM instrumentation. Do not submit apps with LLVM profiling instrumentation or coverage collection enabled. Turn off LLVM profiling or code coverage, rebuild your app and resubmit the app.

It appears that this is being cause because Code Coverage is enabled on this framework.

For more information please visit:

Carthage/Carthage#2056

Carthage/Checkouts/bms-clientsdk-swift-push/Carthage/Checkouts/bms-clientsdk-swift-core/Carthage/Checkouts/bms-clientsdk-swift-analytics-api/BMSAnalyticsAPI.xcodeproj/xcshareddata/xcschemes/BMSAnalyticsAPI iOS.xcscheme: codeCoverageEnabled = "YES">
Carthage/Checkouts/bms-clientsdk-swift-push/Carthage/Checkouts/bms-clientsdk-swift-core/Carthage/Checkouts/bms-clientsdk-swift-analytics-api/BMSAnalyticsAPI.xcodeproj/xcshareddata/xcschemes/BMSAnalyticsAPI Tests.xcscheme: codeCoverageEnabled = "YES">
Carthage/Checkouts/bms-clientsdk-swift-push/Carthage/Checkouts/bms-clientsdk-swift-core/Carthage/Checkouts/bms-clientsdk-swift-analytics-api/BMSAnalyticsAPI.xcodeproj/xcshareddata/xcschemes/BMSAnalyticsAPI watchOS.xcscheme: codeCoverageEnabled = "YES">

[AnanthaKrish]

Its a BMSAnalyticsAPI issue I guess. I will open A ticket there. Thanks for pointing this out ..

[zirinisp]

The issue is with both frameworks. Check out the bold line:

Carthage/Checkouts/bms-clientsdk-swift-analytics-api/BMSAnalyticsAPI.xcodeproj/xcshareddata/xcschemes/BMSAnalyticsAPI iOS.xcscheme: codeCoverageEnabled = "YES">
Carthage/Checkouts/bms-clientsdk-swift-analytics-api/BMSAnalyticsAPI.xcodeproj/xcshareddata/xcschemes/BMSAnalyticsAPI Tests.xcscheme: codeCoverageEnabled = "YES">
Carthage/Checkouts/bms-clientsdk-swift-analytics-api/BMSAnalyticsAPI.xcodeproj/xcshareddata/xcschemes/BMSAnalyticsAPI watchOS.xcscheme: codeCoverageEnabled = "YES">
Carthage/Checkouts/bms-clientsdk-swift-core/BMSCore.xcodeproj/xcshareddata/xcschemes/BMSCore Tests.xcscheme: codeCoverageEnabled = "YES">
Carthage/Checkouts/bms-clientsdk-swift-core/Carthage/Checkouts/bms-clientsdk-swift-analytics-api/BMSAnalyticsAPI.xcodeproj/xcshareddata/xcschemes/BMSAnalyticsAPI iOS.xcscheme: codeCoverageEnabled = "YES">
Carthage/Checkouts/bms-clientsdk-swift-core/Carthage/Checkouts/bms-clientsdk-swift-analytics-api/BMSAnalyticsAPI.xcodeproj/xcshareddata/xcschemes/BMSAnalyticsAPI Tests.xcscheme: codeCoverageEnabled = "YES">
Carthage/Checkouts/bms-clientsdk-swift-core/Carthage/Checkouts/bms-clientsdk-swift-analytics-api/BMSAnalyticsAPI.xcodeproj/xcshareddata/xcschemes/BMSAnalyticsAPI watchOS.xcscheme: codeCoverageEnabled = "YES">
Carthage/Checkouts/bms-clientsdk-swift-push/BMSPush.xcodeproj/xcshareddata/xcschemes/BMSPushTests.xcscheme: codeCoverageEnabled = "YES">
Carthage/Checkouts/bms-clientsdk-swift-push/Carthage/Checkouts/bms-clientsdk-swift-core/BMSCore.xcodeproj/xcshareddata/xcschemes/BMSCore Tests.xcscheme: codeCoverageEnabled = "YES">
Carthage/Checkouts/bms-clientsdk-swift-push/Carthage/Checkouts/bms-clientsdk-swift-core/Carthage/Checkouts/bms-clientsdk-swift-analytics-api/BMSAnalyticsAPI.xcodeproj/xcshareddata/xcschemes/BMSAnalyticsAPI iOS.xcscheme: codeCoverageEnabled = "YES">
Carthage/Checkouts/bms-clientsdk-swift-push/Carthage/Checkouts/bms-clientsdk-swift-core/Carthage/Checkouts/bms-clientsdk-swift-analytics-api/BMSAnalyticsAPI.xcodeproj/xcshareddata/xcschemes/BMSAnalyticsAPI Tests.xcscheme: codeCoverageEnabled = "YES">
Carthage/Checkouts/bms-clientsdk-swift-push/Carthage/Checkouts/bms-clientsdk-swift-core/Carthage/Checkouts/bms-clientsdk-swift-analytics-api/BMSAnalyticsAPI.xcodeproj/xcshareddata/xcschemes/BMSAnalyticsAPI watchOS.xcscheme: codeCoverageEnabled = "YES">

[AnanthaKrish]

@zirinisp I have already removed it . Will release updated version in sometime .

[AnanthaKrish]

@zirinisp Please do the following,

1. Go to the carthage/checkouts
2. Open the BMSxxxx project that you are facing issue in Xcode
3. disable the Code coverage in build settings.
4. Do carthage build in your project again. (Do not do Carthage Update)

This will solve your issue.

[zirinisp]

Thank you for you reply. I am aware of the temporary fix and have already implemented it. I was looking for a permanent one, so we can do Carthage update without problems. M

On Thu, 14 Sep 2017 at 19:28, Anantha Krishnan K G ***@***.***> wrote: @zirinisp <https://github.com/zirinisp> Please do the following, 1. Go to the carthage/checkouts 2. Open the BMSxxxx project that you are facing issue in Xcode 3. disable the Code coverage in build settings. 4. Do carthage build in your project again. (Do not do Carthage Update) This will solve your issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACzascq4ob-InsZ-xVnbbyZ4Mh5tGYyvks5siVRIgaJpZM4PXQIM> .

-- -- *Pantelis Zirinis* www.paz-labs.com 27 Old Gloucester Street London WC1N 3AX United Kingdom Tel: +447957199011 / +44 203 129 0296 / +302109616212 E-mail: info@paz-labs.com Facebook: http://www.facebook.com/PAZLabs

[AnanthaKrish]

@zirinisp We are aware of this. Disabling the Code coverage on our SDKs will impact in the quality of SDKs. Its being monitored. I will try to get a permanent solution. Will come back to you soon... We are also following this Carthage/Carthage#2056

[zirinisp]

I am glad you are monitoring this.

For the moment a nice solution is in the answer of my stackoverflow question. It disables code coverage in all Carthage dependencies.

https://stackoverflow.com/questions/46160518/xcode-9-carthage-itunes-connect-error-invalid-bundle-disallowed-llvm-instr

In my opinion Carthage should implement that with a flag and make everyone’s life easier.

I hope a solution is found.

[AnanthaKrish]

@zirinisp Exactly... Its not good go and disable code coverage in all frameworks we use. But for now thats the only neat solution we have. Carthage should fix it.

[sarah-j-smith]

I am still experiencing this issue with Carthage 0.27.0 and some AWS iOS SDK frameworks, and some other frameworks.

[AnanthaKrish]

@sarah-j-smith

Please do the following,

Go to the carthage/checkouts
Open the BMSxxxx project that you are facing issue in Xcode
disable the Code coverage in build settings.
Do carthage build in your project again. (Do not do Carthage Update)

This will solve your issue.