ibm-js/dapp

jshint exception flags clean up

cjolif opened this issue · 3 comments

There are tons on jshint exception flags in tests. I suspect most of them are actually not needed (for example I found some occurrences of "nonew" that are not needed) but just copy/pasted from one test to another. Also when a param is not needed in a function I think it is better to not list it than adding a jshint exception (for the test, for the lib it is different as we want to document it)

I think exception should stay exceptions otherwise this ends up not being respected (I agree tests are not as important as lib code but better to do it consistently everywhere)

Agreed, I will cleanup the jshint flags in the tests.

Cleanup has begun, I will cleanup any tests that I happen to be updating as I go along, until I have a chance to update all of the remaining tests.

These are done with this commit:
c50d40d