Replacing react-router with react-router-dom

Question

Replacing react-router with react-router-dom

Closed this issue 3 years ago · 2 comments

I see for this issue you removed the react-router-dom dependency. Since react-router-dom imports and re-exports all the components of react-router, isn't it better to replace react-router with react-router-dom which would give the NavLink that you needed for the test. Or is there any use case that I might be missing? Thanks @icd2k3

Answer 1 · 2021-10-23T20:56:33.000Z

oh interesting... yea maybe we should replace it here 🤔

Answer 2 · 2021-10-25T22:35:02.000Z

Opened a PR for you to review. Let me know if I missed anything.